Skip to content

feat(@angular/cli): use eval-source-map for serve on dev targets - #7919

Merged
Brocco merged 1 commit into
angular:masterfrom
filipesilva:dev-eval-sourcemap
Oct 5, 2017
Merged

feat(@angular/cli): use eval-source-map for serve on dev targets#7919
Brocco merged 1 commit into
angular:masterfrom
filipesilva:dev-eval-sourcemap

Conversation

@filipesilva

@filipesilva filipesilva commented Oct 3, 2017

Copy link
Copy Markdown
Contributor

This should improve rebuild speeds for ng serve with sourcemaps on. It doesn't affect ng build or production targets.

hansl
hansl previously approved these changes Oct 3, 2017
@filipesilva filipesilva changed the title feat(@angular/cli): use eva source map for dev targets feat(@angular/cli): use eval-source-map for serve on dev targets Oct 4, 2017
@Brocco
Brocco merged commit 08b284e into angular:master Oct 5, 2017
@filipesilva
filipesilva deleted the dev-eval-sourcemap branch October 9, 2017 16:26
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 9, 2017
Also add test to ensure it doesn't break.

Followup to angular#7919
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 10, 2017
Also add test to ensure it doesn't break.

Followup to angular#7919
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 10, 2017
Using eval sourcemaps (angular#7919) the sourcemap will be included inside the source, and may change slightly even though the source has not. This busts the cache.

A better way to determine if the entry changed is the `rendered` boolean.
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Oct 10, 2017
Also add test to ensure it doesn't break.

Followup to angular#7919
hansl pushed a commit that referenced this pull request Oct 10, 2017
Also add test to ensure it doesn't break.

Followup to #7919
hansl pushed a commit that referenced this pull request Oct 10, 2017
Also add test to ensure it doesn't break.

Followup to #7919
hansl pushed a commit that referenced this pull request Oct 10, 2017
Using eval sourcemaps (#7919) the sourcemap will be included inside the source, and may change slightly even though the source has not. This busts the cache.

A better way to determine if the entry changed is the `rendered` boolean.
hansl pushed a commit that referenced this pull request Oct 10, 2017
Using eval sourcemaps (#7919) the sourcemap will be included inside the source, and may change slightly even though the source has not. This busts the cache.

A better way to determine if the entry changed is the `rendered` boolean.
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Also add test to ensure it doesn't break.

Followup to angular#7919
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Using eval sourcemaps (angular#7919) the sourcemap will be included inside the source, and may change slightly even though the source has not. This busts the cache.

A better way to determine if the entry changed is the `rendered` boolean.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants